android_webview/tools/webview_licenses.py - Issue 660163002: Collect license version as an optional_key in licenses.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/tools/webview_licenses.py

Issue 660163002: Collect license version as an optional_key in licenses.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added optional_keys kwarg to ParseDir Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/tools/webview_licenses.py

diff --git a/android_webview/tools/webview_licenses.py b/android_webview/tools/webview_licenses.py

index 01b271540994b03848120ef8bf47e7b658e5dbe8..a85b0797681e4a10cdd6ea6e0970827050178a3c 100755

--- a/android_webview/tools/webview_licenses.py

+++ b/android_webview/tools/webview_licenses.py

@@ -63,7 +63,8 @@ def GetIncompatibleDirectories():

continue

try:

metadata = licenses.ParseDir(directory, REPOSITORY_ROOT,

- require_license_file=False)

+ require_license_file=False,

+ optional_keys=['License Android Compatible'])

except licenses.LicenseError as e:

print 'Got LicenseError while scanning ' + directory

raise

« no previous file with comments | « no previous file | tools/licenses.py » ('j') | tools/licenses.py » ('J')