Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 66016: Let WebKit draw the active highlight for FindInPage (Closed)

Created:
11 years, 8 months ago by Finnur
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Let WebKit draw the active highlight for FindInPage, instead of using the SelectionController. This fixes a couple of bugs, such as: Active match highlighting disappears when mouse selection is made within the page and selection color is orange (6145). and Selection color becomes orange in some cases on tabs that don't have a Find box open. and Gmail jumping to the first match if on FindNext if Find box is closed and reopened (9795). NOTE: This patch depends on my patch to WebKit that just got accepted. See: https://bugs.webkit.org/show_bug.cgi?id=25102 BUG=6145, 9795 TEST=Find something on a page that results in multiple matches being found. Highlight another word that is not currently highlighted. You should see both active and inactive highlights (orange and yellow) and a blue colored selection highlight. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13510

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M webkit/glue/webframe_impl.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M webkit/glue/webframe_impl.cc View 1 9 chunks +27 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
Hmm... Did I forget to send out a review request or is the review email ...
11 years, 8 months ago (2009-04-09 23:38:21 UTC) #1
darin (slow to review)
11 years, 8 months ago (2009-04-09 23:50:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698