Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 660133003: Fix gtest_filter passed for Site Isolation FYI builders. (Closed)

Created:
6 years, 2 months ago by alexmos
Modified:
6 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Fix gtest_filter passed for Site Isolation FYI builders. * pass --site-per-process and --gtest_filter as separate arguments (this was breaking the windows bot) * use wildcards for better readability * fix syntax by removing the extra "-" from the list of failing tests * remove a test that we've recently fixed from the list BUG=417518 Committed: https://crrev.com/2d3e95119f1fc88e67157d12e708bd9a92224b37 Cr-Commit-Position: refs/heads/master@{#300059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
alexmos
Hi Dirk, could you please review these tweaks to dynamic test config for site isolation ...
6 years, 2 months ago (2014-10-17 01:46:20 UTC) #2
Dirk Pranke
lgtm
6 years, 2 months ago (2014-10-17 02:48:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660133003/1
6 years, 2 months ago (2014-10-17 02:56:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 04:09:02 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 04:09:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d3e95119f1fc88e67157d12e708bd9a92224b37
Cr-Commit-Position: refs/heads/master@{#300059}

Powered by Google App Engine
This is Rietveld 408576698