Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 66013002: Add a wrapper script for GN to depot_tools (Closed)

Created:
7 years, 1 month ago by brettw
Modified:
7 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add a wrapper script for GN to depot_tools This automatically searches the path for a source root (or takes one from the command line), and then executes the current platform's GN binary inside that source tree. This will allow the user to have a "gn" command on their path, and allow our scripts to run GN without having to bake-in the logic for finding the correct platform's GN binary.

Patch Set 1 #

Patch Set 2 : #

Total comments: 9

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
A gn View 1 1 chunk +8 lines, -0 lines 0 comments Download
A gn.bat View 1 1 chunk +10 lines, -0 lines 0 comments Download
A gn.py View 1 2 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
7 years, 1 month ago (2013-11-08 00:34:28 UTC) #1
M-A Ruel
a few comments but lgtm https://codereview.chromium.org/66013002/diff/30001/gn.py File gn.py (right): https://codereview.chromium.org/66013002/diff/30001/gn.py#newcode6 gn.py:6: # This script is ...
7 years, 1 month ago (2013-11-08 00:48:31 UTC) #2
brettw
https://codereview.chromium.org/66013002/diff/30001/gn.py File gn.py (right): https://codereview.chromium.org/66013002/diff/30001/gn.py#newcode52 gn.py:52: raise PlatformUnknownError('Unknown platform for GN: ' + sys.platform) I ...
7 years, 1 month ago (2013-11-08 20:49:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/66013002/80001
7 years, 1 month ago (2013-11-08 20:49:23 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 20:51:42 UTC) #5
Message was sent while issue was closed.
Change committed as 233983

Powered by Google App Engine
This is Rietveld 408576698