chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc - Issue 660123003: Standardize usage of virtual/override/final in chrome/browser/policy/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

Issue 660123003: Standardize usage of virtual/override/final in chrome/browser/policy/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc ('k') | chrome/browser/policy/cloud/policy_header_service_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

diff --git a/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc b/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

index ee5a06a9a8fe1786b63bb2bea6ea89d327f2ea02..c69fccfcc20dae95ce6d12f85b31d00907cd3233 100644

--- a/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

+++ b/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

@@ -105,7 +105,7 @@ class ComponentCloudPolicyTest : public ExtensionBrowserTest {

ComponentCloudPolicyTest() {}

virtual ~ComponentCloudPolicyTest() {}

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ void SetUpCommandLine(CommandLine* command_line) override {

ExtensionBrowserTest::SetUpCommandLine(command_line);

#if defined(OS_CHROMEOS)

// ExtensionBrowserTest sets the login users to a non-managed value;

@@ -116,7 +116,7 @@ class ComponentCloudPolicyTest : public ExtensionBrowserTest {

#endif

}

- virtual void SetUpInProcessBrowserTestFixture() override {

+ void SetUpInProcessBrowserTestFixture() override {

test_server_.RegisterClient(kDMToken, kDeviceID);

EXPECT_TRUE(test_server_.UpdatePolicyData(

dm_protocol::kChromeExtensionPolicyType, kTestExtension, kTestPolicy));

@@ -129,7 +129,7 @@ class ComponentCloudPolicyTest : public ExtensionBrowserTest {

ExtensionBrowserTest::SetUpInProcessBrowserTestFixture();

}

- virtual void SetUpOnMainThread() override {

+ void SetUpOnMainThread() override {

ASSERT_TRUE(PolicyServiceIsEmpty(g_browser_process->policy_service()))

<< "Pre-existing policies in this machine will make this test fail.";