chrome/browser/policy/cloud/cloud_policy_invalidator.h - Issue 660123003: Standardize usage of virtual/override/final in chrome/browser/policy/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/cloud_policy_invalidator.h

Issue 660123003: Standardize usage of virtual/override/final in chrome/browser/policy/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/cloud_policy_browsertest.cc ('k') | chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/cloud/cloud_policy_invalidator.h

diff --git a/chrome/browser/policy/cloud/cloud_policy_invalidator.h b/chrome/browser/policy/cloud/cloud_policy_invalidator.h

index eeb12b5b3c8e484aa88ef6520e2160b40ff42b53..ab9c068d363d1fbaddf40fd47553ca4a7535069a 100644

--- a/chrome/browser/policy/cloud/cloud_policy_invalidator.h

+++ b/chrome/browser/policy/cloud/cloud_policy_invalidator.h

@@ -72,7 +72,7 @@ class CloudPolicyInvalidator : public syncer::InvalidationHandler,

const scoped_refptr<base::SequencedTaskRunner>& task_runner,

scoped_ptr<base::Clock> clock,

int64 highest_handled_invalidation_version);

- virtual ~CloudPolicyInvalidator();

+ ~CloudPolicyInvalidator() override;

// Initializes the invalidator. No invalidations will be generated before this

// method is called. This method must only be called once.

@@ -95,20 +95,19 @@ class CloudPolicyInvalidator : public syncer::InvalidationHandler,

}

// syncer::InvalidationHandler:

- virtual void OnInvalidatorStateChange(

- syncer::InvalidatorState state) override;

- virtual void OnIncomingInvalidation(

+ void OnInvalidatorStateChange(syncer::InvalidatorState state) override;

+ void OnIncomingInvalidation(

const syncer::ObjectIdInvalidationMap& invalidation_map) override;

- virtual std::string GetOwnerName() const override;

+ std::string GetOwnerName() const override;

// CloudPolicyCore::Observer:

- virtual void OnCoreConnected(CloudPolicyCore* core) override;

- virtual void OnRefreshSchedulerStarted(CloudPolicyCore* core) override;

- virtual void OnCoreDisconnecting(CloudPolicyCore* core) override;

+ void OnCoreConnected(CloudPolicyCore* core) override;

+ void OnRefreshSchedulerStarted(CloudPolicyCore* core) override;

+ void OnCoreDisconnecting(CloudPolicyCore* core) override;

// CloudPolicyStore::Observer:

- virtual void OnStoreLoaded(CloudPolicyStore* store) override;

- virtual void OnStoreError(CloudPolicyStore* store) override;

+ void OnStoreLoaded(CloudPolicyStore* store) override;

+ void OnStoreError(CloudPolicyStore* store) override;

private:

// Handle an invalidation to the policy.