Detect built-in varyings' invariant setting conflicts.

Detect built-in varyings' invariant setting conflicts.

BUG=421710
TEST=conformance/glsl/misc/shaders-with-invariance.html
R=bajones@chromium.org

Committed: https://crrev.com/ad0c1301fccf741de2cc182d0c2b5a63841b3ace
Cr-Commit-Position: refs/heads/master@{#300580}

[Zhenyao Mo, 2014-10-16 22:05:24]

Please take a look.

This depends on ANGLE side CL:
https://chromium-review.googlesource.com/#/c/223610/

[bajones, 2014-10-16 22:12:18]

LGTM with one nit.

https://codereview.chromium.org/660123002/diff/1/gpu/command_buffer/service/p...
File gpu/command_buffer/service/program_manager.cc (right):

https://codereview.chromium.org/660123002/diff/1/gpu/command_buffer/service/p...
gpu/command_buffer/service/program_manager.cc:1118: fragment_varyings,
"gl_FragCoord");;
Extra ";" at the line end here.

[Zhenyao Mo, 2014-10-16 22:14:11]

https://codereview.chromium.org/660123002/diff/1/gpu/command_buffer/service/p...
File gpu/command_buffer/service/program_manager.cc (right):

https://codereview.chromium.org/660123002/diff/1/gpu/command_buffer/service/p...
gpu/command_buffer/service/program_manager.cc:1118: fragment_varyings,
"gl_FragCoord");;
On 2014/10/16 22:12:18, bajones wrote:
> Extra ";" at the line end here.

Done.

[Zhenyao Mo, 2014-10-21 17:33:59]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2014-10-21 17:35:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660123002/40001

[commit-bot: I haz the power, 2014-10-21 17:53:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-21 17:53:46]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[Zhenyao Mo, 2014-10-21 19:21:37]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2014-10-21 19:22:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660123002/60001

[commit-bot: I haz the power, 2014-10-21 20:47:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-21 20:47:13]

Try jobs failed on following builders:
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Zhenyao Mo, 2014-10-21 21:34:04]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2014-10-21 21:35:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660123002/80001

[commit-bot: I haz the power, 2014-10-22 00:24:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-10-22 00:25:18]

Patchset 5 (id:??) landed as
https://crrev.com/ad0c1301fccf741de2cc182d0c2b5a63841b3ace
Cr-Commit-Position: refs/heads/master@{#300580}