Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 66010: Merge 13388 - Properly handle empty components when converting url_parse::Par... (Closed)

Created:
11 years, 8 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/
Visibility:
Public.

Description

Merge 13388 - Properly handle empty components when converting url_parse::Parsed object. Add a unittest for the below bug. BUG=9859 Review URL: http://codereview.chromium.org/62162 TBR=estade@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13471

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/autocomplete/autocomplete_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/url_fixer_upper.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 8 months ago (2009-04-09 22:18:46 UTC) #1
Evan Stade
11 years, 8 months ago (2009-04-09 22:42:38 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698