gpu/command_buffer/service/program_cache.cc - Issue 660093004: Type conversion fixes, gpu/ edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/program_cache.cc

Issue 660093004: Type conversion fixes, gpu/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/program_cache.cc

diff --git a/gpu/command_buffer/service/program_cache.cc b/gpu/command_buffer/service/program_cache.cc

index ad395c7f4766d16a0ec9c93e0b1cb2c1ca1a6284..abdcfc0cb5db653fb3df311aea6ff5a43a73a855 100644

--- a/gpu/command_buffer/service/program_cache.cc

+++ b/gpu/command_buffer/service/program_cache.cc

@@ -123,9 +123,9 @@ void ProgramCache::ComputeProgramHash(

current_pos += name_size;

const GLint value = it->second;

buffer[current_pos++] = value >> 24;

- buffer[current_pos++] = value >> 16;

- buffer[current_pos++] = value >> 8;

- buffer[current_pos++] = value;

+ buffer[current_pos++] = static_cast<unsigned char>(value >> 16);

+ buffer[current_pos++] = static_cast<unsigned char>(value >> 8);

+ buffer[current_pos++] = static_cast<unsigned char>(value);

}

base::SHA1HashBytes(buffer.get(),