Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: gpu/command_buffer/service/texture_manager.cc

Issue 660093004: Type conversion fixes, gpu/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/texture_manager.cc
diff --git a/gpu/command_buffer/service/texture_manager.cc b/gpu/command_buffer/service/texture_manager.cc
index 45aaa658e6809b67cf65373f3aab16ee271388a0..122b948cfa70e196ae6d06b15781ae3ad1bdcc57 100644
--- a/gpu/command_buffer/service/texture_manager.cc
+++ b/gpu/command_buffer/service/texture_manager.cc
@@ -1292,8 +1292,9 @@ void TextureManager::SetParameterf(
GLenum result = texture->SetParameterf(feature_info_.get(), pname, param);
if (result != GL_NO_ERROR) {
if (result == GL_INVALID_ENUM) {
- ERRORSTATE_SET_GL_ERROR_INVALID_ENUM(
- error_state, function_name, param, "param");
no sievers 2014/10/16 23:52:08 I think this is a typo here. If the error is INVAL
Peter Kasting 2014/10/17 00:00:40 So, like this?: ERRORSTATE_SET_GL_ERROR_INV
no sievers 2014/10/17 00:06:24 Yes.
+ ERRORSTATE_SET_GL_ERROR_INVALID_ENUM(error_state, function_name,
+ static_cast<unsigned int>(param),
+ "param");
} else {
ERRORSTATE_SET_GL_ERROR_INVALID_PARAMF(
error_state, result, function_name, pname, param);

Powered by Google App Engine
This is Rietveld 408576698