content/renderer/render_frame_impl.cc - Issue 660093003: Detach RemoteFrame from the tree when deleting RenderFrameProxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 660093003: Detach RemoteFrame from the tree when deleting RenderFrameProxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't delete top-level proxy through IPC message. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_proxy_host.cc ('k') | content/renderer/render_frame_proxy.h » ('j') | content/renderer/render_frame_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 0773d410a668139f071d9f8a13140f3ce6ba9f59..1ebf72aec18b07e25790ee75cc8a8bc7b5ee227a 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -598,6 +598,9 @@ RenderFrameImpl::~RenderFrameImpl() {

render_view_->UnregisterVideoHoleFrame(this);

#endif

+ if (render_frame_proxy_)

+ delete render_frame_proxy_;

Charlie Reis 2014/10/16 23:17:56 Worth a DCHECK that we're the main frame, or is th

nasko 2014/10/16 23:21:09 The web_frame_, which knows where in the frame tre

render_view_->UnregisterRenderFrame(this);

g_routing_id_frame_map.Get().erase(routing_id_);

RenderThread::Get()->RemoveRoute(routing_id_);

« no previous file with comments | « content/browser/frame_host/render_frame_proxy_host.cc ('k') | content/renderer/render_frame_proxy.h » ('j') | content/renderer/render_frame_proxy.cc » ('J')