src/hydrogen.cc - Issue 660083005: AstNumberingVisitor does the work of AstConstructionVisitor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 660083005: AstNumberingVisitor does the work of AstConstructionVisitor (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 7b1e5b12b0fc1de0a699d9c1dcea2dacdb135ae5..dd3453f8a3173f2e3bc8aa32ee3cb6152a7fc59a 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -7848,7 +7848,8 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,

target_info.SetAstValueFactory(top_info()->ast_value_factory(), false);

Handle<SharedFunctionInfo> target_shared(target->shared());

if (!Parser::Parse(&target_info) || !Scope::Analyze(&target_info) ||

- !AstNumbering::Renumber(target_info.function(), target_info.zone())) {

+ !AstNumbering::Renumber(target_info.function(), target_info.shared_info(),

+ target_info.zone())) {

if (target_info.isolate()->has_pending_exception()) {

// Parse or scope error, never optimize this function.

SetStackOverflow();

« src/ast-numbering.cc ('K') | « src/full-codegen.cc ('k') | src/liveedit.h » ('j') | no next file with comments »