Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: content/browser/frame_host/frame_tree.cc

Issue 660083003: Fix support for multiple frames per SiteInstance in CreateProxiesForSiteInstance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/frame_tree.cc
diff --git a/content/browser/frame_host/frame_tree.cc b/content/browser/frame_host/frame_tree.cc
index 90c1f8d343f56497862403d4ee851bc913ea3480..0f679e8ca6088e80e5eff32f9c37a772f603acd1 100644
--- a/content/browser/frame_host/frame_tree.cc
+++ b/content/browser/frame_host/frame_tree.cc
@@ -54,7 +54,13 @@ bool ResetNodesForNewProcess(RenderViewHost* render_view_host,
bool CreateProxyForSiteInstance(const scoped_refptr<SiteInstance>& instance,
FrameTreeNode* node) {
- node->render_manager()->CreateRenderFrameProxy(instance.get());
+ // If a new frame is created in an existing SiteInstance, the other frames in
+ // that SiteInstance don't need a proxy for the new frame.
+ SiteInstance* current_instance =
+ node->render_manager()->current_frame_host()->GetSiteInstance();
Charlie Reis 2014/10/21 22:31:27 What about the SiteInstances that already have Ren
+ if (current_instance != instance.get()) {
nasko 2014/10/21 22:25:23 nit: one line if statements don't need {}
+ node->render_manager()->CreateRenderFrameProxy(instance.get());
+ }
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698