Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 660077: NOT FOR COMMITTING: Add fast side-effect free floating point expressions. (Closed)

Created:
10 years, 10 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add fast side-effect free floating point expressions. This will not be committed in this form, so it does not need LGTM approval.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Total comments: 19

Patch Set 11 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+732 lines, -11 lines) Patch
M src/SConscript View 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M src/flag-definitions.h View 7 8 9 10 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 6 7 8 9 10 12 chunks +36 lines, -10 lines 0 comments Download
A src/ia32/safe-codegen-ia32.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +129 lines, -0 lines 0 comments Download
A src/ia32/safe-codegen-ia32.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +557 lines, -0 lines 0 comments Download
M src/v8-counters.h View 7 8 9 10 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
William Hesse
Here are two skeletal files to be filled in with the implementation of safe expressions.
10 years, 10 months ago (2010-02-25 11:50:06 UTC) #1
Lasse Reichstein
LGTM - as a work in progress. http://codereview.chromium.org/660077/diff/1002/1003 File src/ia32/safe-codegen-ia32.h (right): http://codereview.chromium.org/660077/diff/1002/1003#newcode78 src/ia32/safe-codegen-ia32.h:78: int xmm_stack_height_; ...
10 years, 10 months ago (2010-02-25 12:00:21 UTC) #2
Kevin Millikin (Chromium)
General comments: 1. The .gyp project file needs to be updated for the added files. ...
10 years, 9 months ago (2010-02-28 10:20:29 UTC) #3
William Hesse
10 years, 9 months ago (2010-03-01 16:05:06 UTC) #4
All suggested changes made, except that LoadFromSlot is a private method of
CodeGenerator.  Note that I am not planning to commit this change - it is
experimental.

Powered by Google App Engine
This is Rietveld 408576698