Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 660075: Don't run URLFetcherBadHTTPSTest.BadHTTPSTest under Valgrind... (Closed)

Created:
10 years, 10 months ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
CC:
chromium-reviews, not_the_right_glider, stuartmorgan, dank, Paweł Hajdan Jr.
Visibility:
Public.

Description

Don't run some tests failing on certificate erros under Valgrind BUG=36770 TEST=Memory Waterfall should become greener Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40005

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/test/data/valgrind/unit_tests.gtest_linux.txt View 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A net/data/valgrind/net_unittests.gtest_linux.txt View 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Timur Iskhodzhanov
10 years, 10 months ago (2010-02-25 09:50:28 UTC) #1
Alexander Potapenko
On 2010/02/25 09:50:28, Timur Iskhodzhanov wrote: > LGTM
10 years, 10 months ago (2010-02-25 09:54:41 UTC) #2
Hironori Bono
This test fails only on Linux valgrind bots, So, it may be better to change ...
10 years, 10 months ago (2010-02-25 09:54:55 UTC) #3
Timur Iskhodzhanov
I agree, PTAL On 2010/02/25 09:54:55, hbono wrote: > This test fails only on Linux ...
10 years, 10 months ago (2010-02-25 10:10:54 UTC) #4
Hironori Bono
10 years, 10 months ago (2010-02-25 10:13:46 UTC) #5
LGTM.
Thank you for your change.

Regards,

Hironori Bono

Powered by Google App Engine
This is Rietveld 408576698