Only send unprocessed key events upwards if the RenderWidgetHost is not hidde...

Only send unprocessed key events upwards if the RenderWidgetHost is not hidden.

BUG=36661
Ctrl-1 gets queued while Ctrl-tab doesn't
TEST=See bug report.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40085

[Evan Martin, 2010-02-25 07:22:23]

This seems ok to me, but I guess erg/jam are the experts

[Evan Martin, 2010-02-25 08:51:21]

On 2010/02/25 07:22:23, Evan Martin wrote:
> This seems ok to me, but I guess erg/jam are the experts

The reporter points out you can do this:
1) focus slow tab, hit key
2) focus fast tab, do other things
3) focus slow tab, now key comes back.  it will still run

However, maybe this case is too rare to worry about, and I like the simplicity
of this patch.

[James Su, 2010-02-25 09:08:39]

On 2010/02/25 08:51:21, Evan Martin wrote:
> On 2010/02/25 07:22:23, Evan Martin wrote:
> > This seems ok to me, but I guess erg/jam are the experts
> 
> The reporter points out you can do this:
> 1) focus slow tab, hit key
> 2) focus fast tab, do other things
> 3) focus slow tab, now key comes back.  it will still run
> 
> However, maybe this case is too rare to worry about, and I like the simplicity
> of this patch.

I agree. I think it's not worth to deal with such rare case.

[Elliot Glaysher, 2010-02-25 17:34:17]

Seems OK.

On Thu, Feb 25, 2010 at 1:08 AM,  <suzhe@chromium.org> wrote:
> On 2010/02/25 08:51:21, Evan Martin wrote:
>>
>> On 2010/02/25 07:22:23, Evan Martin wrote:
>> > This seems ok to me, but I guess erg/jam are the experts
>
>> The reporter points out you can do this:
>> 1) focus slow tab, hit key
>> 2) focus fast tab, do other things
>> 3) focus slow tab, now key comes back.  it will still run
>
>> However, maybe this case is too rare to worry about, and I like the
>> simplicity
>> of this patch.
>
> I agree. I think it's not worth to deal with such rare case.
>
> http://codereview.chromium.org/660069
>

[James Su, 2010-02-26 01:23:30]

I just submitted. Please tell me if you have any concern.