Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 660063004: mac: Fix BookmarkBarControllerTest.TestClearOnDealloc on Yosemite. (Closed)

Created:
6 years, 2 months ago by erikchen
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

mac: Fix BookmarkBarControllerTest.TestClearOnDealloc on Yosemite. In Yosemite, the owner of a nib file is retain/autoreleased during the initialization of the nib. I wrapped the constructor of the BookmarkBarController in an @autoreleasepool block to allow the test to control the destruction timing of the BookmarkBarController. BUG=390276 Committed: https://crrev.com/1124df6b0a9a980605f8ce342bf1a49403656a84 Cr-Commit-Position: refs/heads/master@{#300312}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
erikchen
rsesek: Please review.
6 years, 2 months ago (2014-10-17 23:03:29 UTC) #3
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-20 15:10:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660063004/20001
6 years, 2 months ago (2014-10-20 18:13:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 2 months ago (2014-10-20 19:22:38 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 19:23:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1124df6b0a9a980605f8ce342bf1a49403656a84
Cr-Commit-Position: refs/heads/master@{#300312}

Powered by Google App Engine
This is Rietveld 408576698