Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 660043002: Add a missing dep on google_apis (Closed)

Created:
6 years, 2 months ago by Jun Mukai
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a missing dep on google_apis BUG=None R=rogerta@chromium.org TEST=manually Committed: https://crrev.com/fefcac1ec8ea501e7c8ff4b3035c1c5af1cee650 Cr-Commit-Position: refs/heads/master@{#299976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M google_apis/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Jun Mukai
6 years, 2 months ago (2014-10-16 17:26:12 UTC) #1
Roger Tawa OOO till Jul 10th
6 years, 2 months ago (2014-10-16 19:31:18 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
6 years, 2 months ago (2014-10-16 19:31:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660043002/1
6 years, 2 months ago (2014-10-16 20:12:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 21:16:57 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 21:17:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fefcac1ec8ea501e7c8ff4b3035c1c5af1cee650
Cr-Commit-Position: refs/heads/master@{#299976}

Powered by Google App Engine
This is Rietveld 408576698