Issue 660003002: Win Video Capture: Correct erroneous DCHECK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660003002: Win Video Capture: Correct erroneous DCHECK (Closed)

Created:
6 years, 2 months ago by mcasas

Modified:
6 years, 2 months ago

Reviewers:
perkj_chrome, tommi (sloooow) - chröme

CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Win Video Capture: Correct erroneous DCHECK Saw failing media_unittests. Introduced by me in https://codereview.chromium.org/649023002/ (surprised it landed in the first place :/ ) BUG= Committed: https://crrev.com/afc200bd7e0a00b538acce743bc98c31495326c3 Cr-Commit-Position: refs/heads/master@{#300078}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	media/video/capture/win/video_capture_device_factory_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660003002/1

6 years, 2 months ago (2014-10-17 07:20:14 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 08:18:01 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/afc200bd7e0a00b538acce743bc98c31495326c3
Cr-Commit-Position: refs/heads/master@{#300078}