Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 659993003: Revert of Change drawText() to generate positions and send to drawPosText() (Closed)

Created:
6 years, 2 months ago by jvanverth1
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Change drawText() to generate positions and send to drawPosText() (patchset #4 id:60001 of https://codereview.chromium.org/653133004/) Reason for revert: A large number of GMs on Ubuntu12 are failing. The text layout on GPU is visibly different than that for 8888. Original issue's description: > Change drawText() to generate positions and send to drawPosText() > > The idea here is to have a central place that does layout for drawText(), and > then always feed text through drawPosText(). This both makes all of the > GrTextContexts consistent in drawText() output, and does a better job of > stressing drawPosText(). > > Because of the effect of matrices on hinting and approximation error, the > generated text is not 100% identical to that produced by the raster pipeline. > > BUG=skia:2778 > > Committed: https://skia.googlesource.com/skia/+/7851a56895c9c076f73a835a7dd51d3c6180c16f TBR=cdalton.nvidia@gmail.com,bungeman@google.com,reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2778 Committed: https://skia.googlesource.com/skia/+/aab626c3670205d02ca42bb34a540f550cb75dc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -79 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M include/core/SkPaint.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrBitmapTextContext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 2 chunks +92 lines, -0 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 4 chunks +78 lines, -10 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 2 chunks +91 lines, -0 lines 0 comments Download
M src/gpu/GrTextContext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 1 chunk +9 lines, -56 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jvanverth1
Created Revert of Change drawText() to generate positions and send to drawPosText()
6 years, 2 months ago (2014-10-16 15:04:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659993003/1
6 years, 2 months ago (2014-10-16 15:04:17 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 15:04:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as aab626c3670205d02ca42bb34a540f550cb75dc2

Powered by Google App Engine
This is Rietveld 408576698