Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 659983002: Block selection gaps are not invalidated (Closed)

Created:
6 years, 2 months ago by Julien - ping for review
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Block selection gaps are not invalidated https://codereview.chromium.org/620553009 moved the selection to invalidate-after-compositing-updates, except that it lied and we still do some invalidations on the spot. This is needed as we don't store the old selection information so we can't generate the old selection invalidation rect later. This change just generates the invalidation on the spot for block selection gaps (like we do for normal selection). The long-term fix will be to store the old rect but it requires more thoughts and we need some quick fix for this nasty issue. BUG=421380 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183890

Patch Set 1 #

Patch Set 2 : Added a TestExpectation for the new test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/selection-partial-invalidation-between-blocks.html View 1 chunk +26 lines, -0 lines 0 comments Download
A + LayoutTests/fast/repaint/selection-partial-invalidation-between-blocks-expected.txt View 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Julien - ping for review
Not super happy about this fix but we need to fix the selection regressions.
6 years, 2 months ago (2014-10-16 19:19:19 UTC) #2
Xianzhu
lgtm for fixing the regression.
6 years, 2 months ago (2014-10-16 20:42:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659983002/1
6 years, 2 months ago (2014-10-16 21:07:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/27307)
6 years, 2 months ago (2014-10-17 03:54:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659983002/20001
6 years, 2 months ago (2014-10-17 13:28:38 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 14:50:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183890

Powered by Google App Engine
This is Rietveld 408576698