Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(1022)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: Source/devtools/scripts/jsdoc-validator/tests/document.js
Issue
659973003
:
[DevTools] Disallow use of global property "document". (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set:
Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
Source/devtools/scripts/jsdoc-validator/hashes
Source/devtools/scripts/jsdoc-validator/jsdoc-validator.jar
Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java
Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/DisallowedGlobalPropertyChecker.java
Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java
Source/devtools/scripts/jsdoc-validator/tests/document.js
Source/devtools/scripts/jsdoc-validator/tests/golden.dat
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java
('K') |
« Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java
('k') |
Source/devtools/scripts/jsdoc-validator/tests/golden.dat »
('j') |
Source/devtools/scripts/jsdoc-validator/tests/golden.dat »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
document.bar();
2
window.document.bar();
3
bar.document();
4
bar.window.document();
5
document();
6
var x = window.document;
7
8
function a(document) {
9
document.bar();
10
document();
11
12
function inner() {
13
var y = document;
14
}
15
}
16
17
function b(bar) {
18
document.bar();
19
document();
20
var document = bar;
21
}
22
23
function c(bar) {
24
document.bar();
25
document();
26
var inner = document + bar;
27
}
28
29
function d(window) {
30
window.document();
31
window.document.bar = 2;
32
}
33
34
/**
35
* @suppressGlobalPropertiesCheck
36
* @param {string} param
37
*/
38
function e(param) {
39
document;
40
window.document;
41
}
42
43
/**
44
* @param {string} param
45
*/
46
function f(param) {
47
document;
48
window.document;
49
}
50
51
var y = x.document;
52
window.x.document();
53
var z = document.document;
54
window.document = bar;
OLD
NEW
« Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java
('K') |
« Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionRecord.java
('k') |
Source/devtools/scripts/jsdoc-validator/tests/golden.dat »
('j') |
Source/devtools/scripts/jsdoc-validator/tests/golden.dat »
('J')
Issue 659973003: [DevTools] Disallow use of global property "document". (Closed)
Created 6 years, 2 months ago by dgozman
Modified 6 years, 1 month ago
Reviewers: apavlov
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 30
This is Rietveld
408576698