Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 659973002: Add missing dependency on TemplateURLService from PrefMetricsService (Closed)

Created:
6 years, 2 months ago by sdefresne
Modified:
6 years, 2 months ago
Reviewers:
*Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add missing dependency on TemplateURLService from PrefMetricsService There is an indirect dependency from PrefMetricsService on TemplateURLService that cause an incorrect ordering of the factories instantiation when using a TestingProfile, as can be seen in the following callstack: TemplateURLServiceFactory::GetForProfile(Profile*) chrome::(anonymous namespace)::GetDefaultSearchProviderTemplateURL(Profile*) chrome::(anonymous namespace)::NewTabURLDetails::ForProfile(Profile*)1 chrome::HandleNewTabURLRewrite(GURL*, content::BrowserContext*) content::BrowserURLHandlerImpl::RewriteURLIfNecessary(GURL*, content::BrowserContext*, bool*) (anonymous namespace)::SampleNewTabPageURL(Profile*) PrefMetricsService::RecordLaunchPrefs() PrefMetricsService::PrefMetricsService(Profile*) PrefMetricsService::Factory::BuildServiceInstanceFor(content::BrowserContext*) Add an explicit dependency to fix the ordering. BUG=373326 Committed: https://crrev.com/15a8709fe24ebb55e15ed88b306d76ad72412931 Cr-Commit-Position: refs/heads/master@{#299890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/prefs/pref_metrics_service.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sdefresne
Please have a look. This is causing the failure of StackedPanelBrowserTest.AddNewPanelFromDifferentProfile in one of my ...
6 years, 2 months ago (2014-10-16 13:03:08 UTC) #3
Bernhard Bauer
lgtm
6 years, 2 months ago (2014-10-16 13:09:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659973002/1
6 years, 2 months ago (2014-10-16 13:27:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64174)
6 years, 2 months ago (2014-10-16 13:37:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659973002/1
6 years, 2 months ago (2014-10-16 14:41:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 14:41:59 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 14:42:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15a8709fe24ebb55e15ed88b306d76ad72412931
Cr-Commit-Position: refs/heads/master@{#299890}

Powered by Google App Engine
This is Rietveld 408576698