Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 659953004: Oilpan: fix build after r183913. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r183913. TBR=oilpan-reviews,haraken BUG=391288 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183928

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M Source/core/dom/FirstLetterPseudoElement.h View 2 chunks +11 lines, -4 lines 0 comments Download
M Source/core/dom/FirstLetterPseudoElement.cpp View 2 chunks +10 lines, -5 lines 0 comments Download
M Source/core/dom/PseudoElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTextFragment.cpp View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 12 (2 generated)
sof
Please take a look.
6 years, 2 months ago (2014-10-17 21:41:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659953004/1
6 years, 2 months ago (2014-10-17 21:42:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 183928
6 years, 2 months ago (2014-10-17 21:43:02 UTC) #4
esprehn
I think you just added a security bug. https://codereview.chromium.org/659953004/diff/1/Source/core/rendering/RenderTextFragment.cpp File Source/core/rendering/RenderTextFragment.cpp (right): https://codereview.chromium.org/659953004/diff/1/Source/core/rendering/RenderTextFragment.cpp#newcode56 Source/core/rendering/RenderTextFragment.cpp:56: #if ...
6 years, 2 months ago (2014-10-17 22:02:05 UTC) #6
sof
https://codereview.chromium.org/659953004/diff/1/Source/core/rendering/RenderTextFragment.cpp File Source/core/rendering/RenderTextFragment.cpp (right): https://codereview.chromium.org/659953004/diff/1/Source/core/rendering/RenderTextFragment.cpp#newcode56 Source/core/rendering/RenderTextFragment.cpp:56: #if !ENABLE(OILPAN) On 2014/10/17 22:02:05, esprehn wrote: > This ...
6 years, 2 months ago (2014-10-18 04:50:52 UTC) #7
dsinclair
On 2014/10/18 04:50:52, sof wrote: > https://codereview.chromium.org/659953004/diff/1/Source/core/rendering/RenderTextFragment.cpp > File Source/core/rendering/RenderTextFragment.cpp (right): > > https://codereview.chromium.org/659953004/diff/1/Source/core/rendering/RenderTextFragment.cpp#newcode56 > ...
6 years, 2 months ago (2014-10-18 04:56:32 UTC) #8
sof
On 2014/10/18 04:56:32, dsinclair wrote: > On 2014/10/18 04:50:52, sof wrote: > > > https://codereview.chromium.org/659953004/diff/1/Source/core/rendering/RenderTextFragment.cpp ...
6 years, 2 months ago (2014-10-18 04:59:46 UTC) #9
sof
On 2014/10/18 04:59:46, sof wrote: > On 2014/10/18 04:56:32, dsinclair wrote: > > On 2014/10/18 ...
6 years, 2 months ago (2014-10-18 05:27:10 UTC) #10
sof
On 2014/10/18 05:27:10, sof wrote: > On 2014/10/18 04:59:46, sof wrote: > > On 2014/10/18 ...
6 years, 2 months ago (2014-10-18 06:59:44 UTC) #11
haraken
6 years, 2 months ago (2014-10-18 11:08:33 UTC) #12
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698