Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 659953002: Add a pure virtual method to the GarbageCollectedMixin class (Closed)

Created:
6 years, 2 months ago by haraken
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, Mads Ager (chromium), webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, mkwst+moarreviews_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, haraken, kouhei+heap_chromium.org, rwlbuis
Project:
blink
Visibility:
Public.

Description

Add a pure virtual method to the GarbageCollectedMixin class It's easy to miss adding USING_GARBAGE_COLLECTED_MIXIN macros to classes that inherit from GarbageCollectedMixin. To avoid the programming error, this CL adds a pure virtual method to the GarbageCollectedMixin class. If we miss the USING_GARBAGE_COLLECTED_MIXIN macro, we'll hit a compile error. This CL also fixes existing programming errors. BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M Source/core/dom/DocumentParserClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportLoader.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImportLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/presentation/Presentation.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationDispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/heap/Visitor.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
haraken
PTAL
6 years, 2 months ago (2014-10-16 09:17:48 UTC) #2
kouhei (in TOK)
s/USEING/USING/g
6 years, 2 months ago (2014-10-16 09:19:37 UTC) #4
sof
lgtm, thanks for fixing.
6 years, 2 months ago (2014-10-16 09:26:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659953002/1
6 years, 2 months ago (2014-10-16 09:42:51 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 10:23:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183799

Powered by Google App Engine
This is Rietveld 408576698