perf/go/logserver/main.go - Issue 659943006: Do not forget to call `defer glog.Flush()` in our applications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: perf/go/logserver/main.go

Issue 659943006: Do not forget to call `defer glog.Flush()` in our applications (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: revert titletool changes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: perf/go/logserver/main.go

diff --git a/perf/go/logserver/main.go b/perf/go/logserver/main.go

index 683a1682a1313d7243e5679953eb434cf923f57d..8d0c1aaa998e28b24ecb72a61ba7ff656c366039 100644

--- a/perf/go/logserver/main.go

+++ b/perf/go/logserver/main.go

@@ -109,6 +109,7 @@ func serveFile(w http.ResponseWriter, r *http.Request, fs http.FileSystem, name

func main() {

flag.Parse()

+ defer glog.Flush()

if err := os.MkdirAll(*dir, 0777); err != nil {

glog.Fatalf("Failed to create dir for log files: %s", err)

« no previous file with comments | « perf/go/ingest/main.go ('k') | perf/go/perf_migratedb/main.go » ('j') | no next file with comments »