Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: monitoring/go/grains/grains.go

Issue 659943006: Do not forget to call `defer glog.Flush()` in our applications (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: revert titletool changes Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « golden/go/skiacorrectness/main.go ('k') | monitoring/go/prober/main.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: monitoring/go/grains/grains.go
diff --git a/monitoring/go/grains/grains.go b/monitoring/go/grains/grains.go
index e4cbe7750f5fee25103d3d7e3995893778119133..2e0562d266512436e901302d9bef97b5e13078dc 100644
--- a/monitoring/go/grains/grains.go
+++ b/monitoring/go/grains/grains.go
@@ -35,11 +35,10 @@ import (
"net/url"
"strings"
+ "github.com/golang/glog"
"skia.googlesource.com/buildbot.git/go/login"
"skia.googlesource.com/buildbot.git/go/metadata"
"skia.googlesource.com/buildbot.git/perf/go/flags"
-
- "github.com/golang/glog"
)
const (
@@ -101,6 +100,7 @@ func (p Proxy) ServeHTTP(w http.ResponseWriter, r *http.Request) {
func main() {
flag.Parse()
flags.Log()
+ defer glog.Flush()
if *useMetadata {
*clientID = metadata.MustGet(CLIENT_ID_METADATA_KEY)
*clientSecret = metadata.MustGet(CLIENT_SECRET_METADATA_KEY)
« no previous file with comments | « golden/go/skiacorrectness/main.go ('k') | monitoring/go/prober/main.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698