crypto/ec_private_key_nss.cc - Issue 659943004: Type conversion fixes, crypto/ edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/ec_private_key_nss.cc

Issue 659943004: Type conversion fixes, crypto/ edition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: crypto/ec_private_key_nss.cc

diff --git a/crypto/ec_private_key_nss.cc b/crypto/ec_private_key_nss.cc

index b38c3966e3300507c0802803376ced8160cc7dad..2daa0c0f4a38642916981996440a084d09f8adc5 100644

--- a/crypto/ec_private_key_nss.cc

+++ b/crypto/ec_private_key_nss.cc

@@ -340,7 +340,7 @@ ECPrivateKey* ECPrivateKey::CreateWithParams(PK11SlotInfo* slot,

};

ec_parameters.data[0] = SEC_ASN1_OBJECT_ID;

- ec_parameters.data[1] = oid_data->oid.len;

+ ec_parameters.data[1] = static_cast<unsigned char>(oid_data->oid.len);

memcpy(ec_parameters.data + 2, oid_data->oid.data, oid_data->oid.len);

result->key_ = PK11_GenerateKeyPair(slot,

« no previous file with comments | « no previous file | crypto/nss_util_unittest.cc » ('j') | no next file with comments »