Type conversion fixes, crypto/ edition.

crypto/nss_util_unittest.cc

Index: crypto/nss_util_unittest.cc
diff --git a/crypto/nss_util_unittest.cc b/crypto/nss_util_unittest.cc
index b68788513c6a441908be43be2eb2fb73c487edf5..fe53e19941bd5b7aa69a3a7ae29ca98ba223912c 100644
--- a/crypto/nss_util_unittest.cc
+++ b/crypto/nss_util_unittest.cc
@@ -19,14 +19,14 @@ TEST(NSSUtilTest, PRTimeConversion) {
   prxtime.tm_params.tp_gmt_offset = 0;
   prxtime.tm_params.tp_dst_offset = 0;
   base::Time::Exploded exploded;
-  prxtime.tm_year = exploded.year = 2011;
+  exploded.year = prxtime.tm_year = 2011;

[Peter Kasting, 2014/10/16 23:25:55]

Note that the ordering changes here aren't just cosmetic; they change to the
following ordering:

  larger type = smaller type = value;

...thus eliminating type downcasting warnings.

[wtc, 2014/10/21 02:08:50]

It might be good to add this comment to the source code.

[Peter Kasting, 2014/10/21 02:20:13]

Done.

   exploded.month = 12;
   prxtime.tm_month = 11;
-  prxtime.tm_wday = exploded.day_of_week = 0;  // Should be unusued.
-  prxtime.tm_mday = exploded.day_of_month = 10;
-  prxtime.tm_hour = exploded.hour = 2;
-  prxtime.tm_min = exploded.minute = 52;
-  prxtime.tm_sec = exploded.second = 19;
+  exploded.day_of_week = prxtime.tm_wday = 0;  // Should be unused.
+  exploded.day_of_month = prxtime.tm_mday = 10;
+  exploded.hour = prxtime.tm_hour = 2;
+  exploded.minute = prxtime.tm_min = 52;
+  exploded.second = prxtime.tm_sec = 19;
   exploded.millisecond = 342;
   prxtime.tm_usec = 342000;