Type conversion fixes, crypto/ edition.

Type conversion fixes, crypto/ edition.

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Committed: https://crrev.com/07551630957d5db1a193bf4314e8c578ff06fc41
Cr-Commit-Position: refs/heads/master@{#300432}

[Peter Kasting, 2014-10-16 23:06:04]

pkasting@chromium.org changed reviewers:
+ wtc@chromium.org

[Peter Kasting, 2014-10-16 23:25:55]

https://codereview.chromium.org/659943004/diff/40001/crypto/nss_util_unittest.cc
File crypto/nss_util_unittest.cc (right):

https://codereview.chromium.org/659943004/diff/40001/crypto/nss_util_unittest...
crypto/nss_util_unittest.cc:22: exploded.year = prxtime.tm_year = 2011;
Note that the ordering changes here aren't just cosmetic; they change to the
following ordering:

  larger type = smaller type = value;

...thus eliminating type downcasting warnings.

[Peter Kasting, 2014-10-20 20:56:16]

Ping for wtc.

[wtc, 2014-10-21 02:08:50]

Patch set 3 LGTM. Thanks.

https://codereview.chromium.org/659943004/diff/40001/crypto/nss_util_unittest.cc
File crypto/nss_util_unittest.cc (right):

https://codereview.chromium.org/659943004/diff/40001/crypto/nss_util_unittest...
crypto/nss_util_unittest.cc:22: exploded.year = prxtime.tm_year = 2011;
It might be good to add this comment to the source code.

[Peter Kasting, 2014-10-21 02:20:13]

Landing.

https://codereview.chromium.org/659943004/diff/40001/crypto/nss_util_unittest.cc
File crypto/nss_util_unittest.cc (right):

https://codereview.chromium.org/659943004/diff/40001/crypto/nss_util_unittest...
crypto/nss_util_unittest.cc:22: exploded.year = prxtime.tm_year = 2011;
On 2014/10/21 02:08:50, wtc wrote:
> It might be good to add this comment to the source code.
> 

Done.

[Peter Kasting, 2014-10-21 02:20:16]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2014-10-21 02:22:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/659943004/60001

[commit-bot: I haz the power, 2014-10-21 07:43:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-21 07:43:59]

Patchset 4 (id:??) landed as
https://crrev.com/07551630957d5db1a193bf4314e8c578ff06fc41
Cr-Commit-Position: refs/heads/master@{#300432}