Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 659943003: Cache important USB string descriptors all at once. (Closed)

Created:
6 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
rpaquay
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cache important USB string descriptors all at once. On platforms without udev support we must open a libusb device handle in order to read string descriptors from the device. Rapidly opening and closing the handle could cause problems with the platform's USB stack so this patch caches the manufacturer, product and serial number strings all at once. It also prevents a leak of the device handle by explicitly closing it. BUG=346953 Committed: https://crrev.com/838d2a5ce4b9fe2ece0d7202c5ea2dfe173aeb89 Cr-Commit-Position: refs/heads/master@{#300116}

Patch Set 1 : #

Patch Set 2 : Fixed typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -81 lines) Patch
M device/usb/usb_device_impl.h View 1 chunk +10 lines, -5 lines 0 comments Download
M device/usb/usb_device_impl.cc View 1 4 chunks +60 lines, -76 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Reilly Grant (use Gerrit)
Please take a look. This fixes the USB device picker on Windows. The issue was ...
6 years, 2 months ago (2014-10-16 21:48:29 UTC) #3
rpaquay
lgtm
6 years, 2 months ago (2014-10-17 15:38:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659943003/40001
6 years, 2 months ago (2014-10-17 15:43:55 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 2 months ago (2014-10-17 16:41:23 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 16:42:03 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/838d2a5ce4b9fe2ece0d7202c5ea2dfe173aeb89
Cr-Commit-Position: refs/heads/master@{#300116}

Powered by Google App Engine
This is Rietveld 408576698