Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 659923002: Revert of Intorduce PowerButtonObserver API (Closed)

Created:
6 years, 2 months ago by jam
Modified:
6 years, 2 months ago
Reviewers:
Jun Mukai, oshima
CC:
chromium-reviews, tdresser+watch_chromium.org, dpolukhin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Intorduce PowerButtonObserver API (patchset #3 id:80001 of https://codereview.chromium.org/654343002/) Reason for revert: This is breaking the main waterfall : http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20(1) It appears that athena_unittests got added to the waterfall and not trybots. Please fix that before relanding this. Original issue's description: > Intorduce PowerButtonObserver API > > renamed existing PowerButtonController to ShutdownDialog > > BUG=None > TEST=covered by unit tests > > Committed: https://crrev.com/0d921cdf45872ebff6c22da6a21c12d44054a860 > Cr-Commit-Position: refs/heads/master@{#299821} TBR=mukai@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/6c29a291f248469a892233e008d3d6568efd6191 Cr-Commit-Position: refs/heads/master@{#299846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -597 lines) Patch
M athena/athena.gyp View 3 chunks +2 lines, -6 lines 0 comments Download
M athena/input/DEPS View 2 chunks +0 lines, -7 lines 0 comments Download
M athena/input/accelerator_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D athena/input/input_manager_impl.h View 1 chunk +0 lines, -65 lines 0 comments Download
M athena/input/input_manager_impl.cc View 4 chunks +42 lines, -34 lines 0 comments Download
D athena/input/input_manager_unittest.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D athena/input/power_button_controller.h View 1 chunk +0 lines, -56 lines 0 comments Download
D athena/input/power_button_controller.cc View 1 chunk +0 lines, -131 lines 0 comments Download
M athena/input/public/input_manager.h View 2 chunks +0 lines, -15 lines 0 comments Download
M athena/system/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A athena/system/power_button_controller.h View 1 chunk +77 lines, -0 lines 0 comments Download
A athena/system/power_button_controller.cc View 1 chunk +126 lines, -0 lines 0 comments Download
D athena/system/shutdown_dialog.h View 1 chunk +0 lines, -69 lines 0 comments Download
D athena/system/shutdown_dialog.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M athena/system/system_ui_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Intorduce PowerButtonObserver API
6 years, 2 months ago (2014-10-16 04:52:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659923002/1
6 years, 2 months ago (2014-10-16 04:53:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 04:54:04 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 04:54:40 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c29a291f248469a892233e008d3d6568efd6191
Cr-Commit-Position: refs/heads/master@{#299846}

Powered by Google App Engine
This is Rietveld 408576698