Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 659883004: settings: rearrange DOM to look better (Closed)

Created:
6 years, 2 months ago by Evan Stade
Modified:
6 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

settings: change CSS to make Reset Settings look better. BUG=423645 Committed: https://crrev.com/34989288c23b9af5d7d6ee3cb053f22d72fd7601 Cr-Commit-Position: refs/heads/master@{#300400}

Patch Set 1 #

Patch Set 2 : better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/options/reset_profile_settings_overlay.css View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Evan Stade
6 years, 2 months ago (2014-10-16 23:28:35 UTC) #2
Dan Beam
i heard you like <span>s lgtm
6 years, 2 months ago (2014-10-17 19:09:57 UTC) #3
Evan Stade
changed the CSS instead. This works well for both single line (English) and multi-line (German?) ...
6 years, 2 months ago (2014-10-17 19:23:37 UTC) #4
Dan Beam
lgtm
6 years, 2 months ago (2014-10-20 23:41:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659883004/20001
6 years, 2 months ago (2014-10-20 23:47:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 01:52:32 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 01:54:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34989288c23b9af5d7d6ee3cb053f22d72fd7601
Cr-Commit-Position: refs/heads/master@{#300400}

Powered by Google App Engine
This is Rietveld 408576698