Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 659873002: Making display list canvases fall back to gpu-accelerated when appropriate (Closed)

Created:
6 years, 2 months ago by Justin Novosad
Modified:
6 years, 2 months ago
Reviewers:
Stephen White
CC:
blink-reviews, krit, pdr+graphicswatchlist_chromium.org, blink-reviews-html_chromium.org, jbroman, mkwst+moarreviews_chromium.org, danakj, dglazkov+blink, Rik, Stephen Chennney, rwlbuis
Project:
blink
Visibility:
Public.

Description

Making display list canvases fall back to gpu-accelerated when appropriate BUG=392606 TEST=RecordingImageBufferSurfaceTest Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183824

Patch Set 1 #

Total comments: 3

Patch Set 2 : response to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -35 lines) Patch
M Source/core/html/HTMLCanvasElement.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 2 chunks +48 lines, -12 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurface.h View 1 3 chunks +21 lines, -2 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurface.cpp View 1 6 chunks +109 lines, -17 lines 0 comments Download
M Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 5 chunks +29 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Justin Novosad
PTAL
6 years, 2 months ago (2014-10-15 22:07:56 UTC) #2
Stephen White
https://codereview.chromium.org/659873002/diff/1/Source/platform/graphics/RecordingImageBufferSurface.cpp File Source/platform/graphics/RecordingImageBufferSurface.cpp (right): https://codereview.chromium.org/659873002/diff/1/Source/platform/graphics/RecordingImageBufferSurface.cpp#newcode132 Source/platform/graphics/RecordingImageBufferSurface.cpp:132: m_fallbackSurface->finalizeFrame(dirtyRect); Nit: could be an early-return here. https://codereview.chromium.org/659873002/diff/1/Source/platform/graphics/RecordingImageBufferSurface.cpp#newcode142 Source/platform/graphics/RecordingImageBufferSurface.cpp:142: ...
6 years, 2 months ago (2014-10-16 14:37:14 UTC) #3
Justin Novosad
Done. New Patch
6 years, 2 months ago (2014-10-16 14:53:12 UTC) #4
Stephen White
LGTM
6 years, 2 months ago (2014-10-16 14:57:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659873002/20001
6 years, 2 months ago (2014-10-16 15:07:20 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 16:01:01 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183824

Powered by Google App Engine
This is Rietveld 408576698