Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 659853002: Fix nacl_integration script since it needs to be updated after test_env.py updates. (Closed)

Created:
6 years, 2 months ago by jam
Modified:
6 years, 2 months ago
Reviewers:
Mark Seaborn, raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix nacl_integration script since it needs to be updated after test_env.py updates. TBR=raymes Committed: https://chromium.googlesource.com/chromium/src/+/7e31938ec36279c2f1a64640aa8e448488cd6b19

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ppapi/native_client/tools/browser_tester/browser_tester.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 10 (3 generated)
jam
6 years, 2 months ago (2014-10-15 21:11:15 UTC) #2
jam
6 years, 2 months ago (2014-10-15 21:12:12 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7e31938ec36279c2f1a64640aa8e448488cd6b19 Cr-Commit-Position: refs/heads/master@{#299764}
6 years, 2 months ago (2014-10-15 21:15:35 UTC) #5
jam
Committed patchset #1 (id:1) manually as 7e31938ec36279c2f1a64640aa8e448488cd6b19 (presubmit successful).
6 years, 2 months ago (2014-10-15 21:15:42 UTC) #6
raymes
rubberstamp lgtm
6 years, 2 months ago (2014-10-15 21:38:25 UTC) #8
Mark Seaborn
https://codereview.chromium.org/659853002/diff/1/ppapi/native_client/tools/browser_tester/browser_tester.py File ppapi/native_client/tools/browser_tester/browser_tester.py (right): https://codereview.chromium.org/659853002/diff/1/ppapi/native_client/tools/browser_tester/browser_tester.py#newcode214 ppapi/native_client/tools/browser_tester/browser_tester.py:214: env.update(test_env.get_sandbox_env(sys.argv, os.environ)) This doesn't look right. Where is "env" ...
6 years, 2 months ago (2014-10-15 22:03:32 UTC) #9
raymes
6 years, 2 months ago (2014-10-15 22:05:25 UTC) #10
See the followup in https://codereview.chromium.org/662503002/

On Wed Oct 15 2014 at 3:03:33 PM <mseaborn@chromium.org> wrote:

>
> https://codereview.chromium.org/659853002/diff/1/ppapi/
> native_client/tools/browser_tester/browser_tester.py
> File ppapi/native_client/tools/browser_tester/browser_tester.py (right):
>
> https://codereview.chromium.org/659853002/diff/1/ppapi/
> native_client/tools/browser_tester/browser_tester.py#newcode214
> ppapi/native_client/tools/browser_tester/browser_tester.py:214
>
<https://codereview.chromium.org/659853002/diff/1/ppapi/native_client/tools/br...>
> :
> env.update(test_env.get_sandbox_env(sys.argv, os.environ))
> This doesn't look right.  Where is "env" defined?  Doesn't pyflakes give
> a warning about this?
>
> What is the test_env change you're changing this to match?
>
> https://codereview.chromium.org/659853002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698