Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 659843002: Let the browser know about the renderer's page id assignments, even if the renderer is swapped out. (Closed)

Created:
6 years, 2 months ago by Avi (use Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
Charlie Reis, nasko
CC:
chromium-reviews, mkwst+moarreviews-ipc_chromium.org, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Let the browser know about the renderer's page id assignments, even if the renderer is swapped out. BUG=407376 TEST=no change Committed: https://crrev.com/c762fb764c6812cc662b125ae69d3421064b1c45 Cr-Commit-Position: refs/heads/master@{#299781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/common/swapped_out_messages.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Avi (use Gerrit)
6 years, 2 months ago (2014-10-15 19:44:41 UTC) #2
Avi (use Gerrit)
6 years, 2 months ago (2014-10-15 19:46:15 UTC) #5
Charlie Reis
LGTM. I agree that RVHI::page_id_ should accurately reflect RVI::page_id_, even when they're swapped out. That ...
6 years, 2 months ago (2014-10-15 19:57:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659843002/1
6 years, 2 months ago (2014-10-15 20:00:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17852)
6 years, 2 months ago (2014-10-15 20:07:34 UTC) #10
nasko
IPC LGTM
6 years, 2 months ago (2014-10-15 20:12:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659843002/1
6 years, 2 months ago (2014-10-15 22:12:00 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 22:17:09 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 22:17:58 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c762fb764c6812cc662b125ae69d3421064b1c45
Cr-Commit-Position: refs/heads/master@{#299781}

Powered by Google App Engine
This is Rietveld 408576698