Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 659833002: Removed unused scrollbar pseudo classes. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 2 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removed unused scrollbar pseudo classes. ::-webkit-scrollbar-back and ::-webkit-scrollbar-forward had PseudoType constants, but the strings were not recognized and no other code for handling them present. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183795

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M Source/core/css/CSSSelector.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rune
6 years, 2 months ago (2014-10-15 18:12:32 UTC) #1
Timothy Loh
On 2014/10/15 18:12:32, rune wrote: lgtm
6 years, 2 months ago (2014-10-16 00:37:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659833002/1
6 years, 2 months ago (2014-10-16 07:48:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/13825)
6 years, 2 months ago (2014-10-16 08:00:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659833002/20001
6 years, 2 months ago (2014-10-16 08:10:07 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 09:12:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183795

Powered by Google App Engine
This is Rietveld 408576698