Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/profiler_macos.cc

Issue 65983005: Post landing fixes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/profiler.cc ('k') | runtime/vm/signal_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler_macos.cc
diff --git a/runtime/vm/profiler_macos.cc b/runtime/vm/profiler_macos.cc
index 83696797027a993a2a95b3434974b34e8d7ef906..1a189f867dc000477fcec1ffdd4e4595129b1a62 100644
--- a/runtime/vm/profiler_macos.cc
+++ b/runtime/vm/profiler_macos.cc
@@ -28,8 +28,8 @@ static void CollectSample(IsolateProfilerData* profiler_data,
// Issue # 14777
sample->vm_tags = Sample::kExecuting;
sample->runtime_tags = 0;
- int64_t cpu_usage;
- Thread::GetThreadCpuUsage(profiler_data->thread_id(), &cpu_usage);
+ int64_t cpu_usage = 0;
+ // TODO(johnmccutchan): Thread::GetThreadCpuUsage on MacOS.
sample->cpu_usage = profiler_data->ComputeDeltaAndSetCpuUsage(cpu_usage);
ProfilerSampleStackWalker stackWalker(sample, stack_lower, stack_upper,
pc, fp, sp);
« no previous file with comments | « runtime/vm/profiler.cc ('k') | runtime/vm/signal_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698