Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 659823003: Nasty hack to pick the right origin for a sheet above an app window. (Closed)

Created:
6 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Nasty hack to pick the right origin for a sheet above an app window. In r546e2e6931 GetSheetParentBoundsForParentView was added to work around the presense of dev tools in the view hierarchy when calculating the center of the web contents view. In an app window there is no dev tools view so this patch falls back to the parent view's normal bounds. BUG= Committed: https://crrev.com/4bc9cfaa94d641be10f1979a347ab50f3dea2b6f Cr-Commit-Position: refs/heads/master@{#299790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Please take a look. This is the hack we discussed over IM.
6 years, 2 months ago (2014-10-15 19:17:53 UTC) #2
Avi (use Gerrit)
LGTM. It would be nice if we could make some kind of containment protocol.
6 years, 2 months ago (2014-10-15 21:12:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659823003/1
6 years, 2 months ago (2014-10-15 21:29:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 00:23:04 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 00:23:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bc9cfaa94d641be10f1979a347ab50f3dea2b6f
Cr-Commit-Position: refs/heads/master@{#299790}

Powered by Google App Engine
This is Rietveld 408576698