Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1710)

Unified Diff: dart/tests/try/web/incremental_compilation_update_test.dart

Issue 659813002: Apply updates to static methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tests/try/web/incremental_compilation_update_test.dart
diff --git a/dart/tests/try/web/incremental_compilation_update_test.dart b/dart/tests/try/web/incremental_compilation_update_test.dart
index 991fbbe8bcce7a7110b99d93a3fd185fa024ab47..db2e40adbb873deed97cf31f1041d167686db8f5 100644
--- a/dart/tests/try/web/incremental_compilation_update_test.dart
+++ b/dart/tests/try/web/incremental_compilation_update_test.dart
@@ -95,8 +95,72 @@ main() {
""",
const <String> ['b a', 'c a']),
],
-];
+ // Test modifying a static method works.
+ const <ProgramResult>[
+ const ProgramResult(
+ """
+class C {
+ static m() {
+ print('v1');
+ }
+}
+main() {
+ C.m();
+}
+""",
+ const <String> ['v1']),
+ const ProgramResult(
+ """
+class C {
+ static m() {
+ print('v2');
+ }
+}
+main() {
+ C.m();
+}
+""",
+ const <String> ['v2']),
+ ],
+
+ // Test modifying an instance method works.
+ const <ProgramResult>[
+ const ProgramResult(
+ """
+class C {
+ m() {
+ print('v1');
+ }
+}
+var instance;
+main() {
+ if (instance == null) {
+ instance = new C();
+ }
+ instance.m();
+}
+""",
+ const <String> ['v1']),
+ const ProgramResult(
+ """
+class C {
+ m() {
+ print('v2');
+ }
+}
+var instance;
+main() {
+ if (instance == null) {
+ instance = new C();
+ }
+ instance.m();
+}
+""",
+ // TODO(ahe): This test is failing, should print "v2".
+ const <String> ['v1']),
+ ],
+];
void main() {
listener.start();
@@ -139,8 +203,9 @@ Future compileAndRun(List<ProgramResult> programs) {
Uri uri = test.scriptUri.resolve('?v${version++}');
inputProvider.cachedSources[uri] = new Future.value(program.code);
Future future = test.incrementalCompiler.compileUpdates(
- {test.scriptUri: uri});
+ {test.scriptUri: uri}, logVerbose: print, logTime: print);
return future.then((String update) {
+ print({'update': update});
Johnni Winther 2014/10/16 07:48:46 Remove debug code.
ahe 2014/10/16 09:19:48 I prefer to keep it. This is a test, after all, an
iframe.contentWindow.postMessage(['apply-update', update], '*');
return listener.expect(

Powered by Google App Engine
This is Rietveld 408576698