Split infobar_delegate.[cc,h] into separate pieces for the different classes defined within, so that

Split infobar_delegate.[cc,h] into separate pieces for the different classes defined within, so that each piece is shorter and clearer.

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76677

[Peter Kasting, 2011-03-01 01:45:45]

Can you split Link and Confirm into separate files in this CL too?

[tfarina, 2011-03-01 01:49:03]

On 2011/03/01 01:45:45, Peter Kasting wrote:
> Can you split Link and Confirm into separate files in this CL too?

I thought in doing them in this CL too. But touching with ConfirmInfoBarDelegate
will affect 48 files (which is something I would like to avoid at least for
now).

[Peter Kasting, 2011-03-01 01:49:59]

On 2011/03/01 01:49:03, tfarina wrote:
> On 2011/03/01 01:45:45, Peter Kasting wrote:
> > Can you split Link and Confirm into separate files in this CL too?
> 
> I thought in doing them in this CL too. But touching with
ConfirmInfoBarDelegate
> will affect 48 files (which is something I would like to avoid at least for
> now).

I would rather not do this change halfway.  If you don't want to touch the other
files then we can just hold off on this.

[tfarina, 2011-03-01 01:50:51]

On 2011/03/01 01:49:59, Peter Kasting wrote:
> On 2011/03/01 01:49:03, tfarina wrote:
> > On 2011/03/01 01:45:45, Peter Kasting wrote:
> > > Can you split Link and Confirm into separate files in this CL too?
> > 
> > I thought in doing them in this CL too. But touching with
> ConfirmInfoBarDelegate
> > will affect 48 files (which is something I would like to avoid at least for
> > now).
> 
> I would rather not do this change halfway.  If you don't want to touch the
other
> files then we can just hold off on this.

OK, if you don't have a problem with this I will do.

[tfarina, 2011-03-01 02:21:08]

Peter, could you take another look?

[Peter Kasting, 2011-03-01 19:10:37]

LGTM

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/tab_contents_ssl_helper.cc (left):

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/tab_contents_ssl_helper.cc:31: 
Nit: This blank line can stay

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:100: #include
"content/browser/tab_contents/infobar_delegate.h"
Nit: Can this disappear?

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/ui/cocoa/info...
File chrome/browser/ui/cocoa/infobars/infobar_test_helper.h (right):

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_test_helper.h:12: //
MockLinkInfoBarDelegate ----------------------------------------------------
Nit: Probably want to split these into two files (and mark all the virtual
functions with OVERRIDE?).  This could be done in a second change if you want.

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/ui/gtk/infoba...
File chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.h (right):

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/ui/gtk/infoba...
chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.h:10: #include
"chrome/browser/tab_contents/confirm_infobar_delegate.h"
Nit: Forward declare instead of adding this

[jam, 2011-03-01 19:14:59]

btw if you have time, if you can move content\browser\infobar_delegate.* to the
files you're deleting here, that'd be great.  I moved them and then we decided
they should have stayed.

[tfarina, 2011-03-02 01:47:13]

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/tab_contents_ssl_helper.cc (left):

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/tab_contents_ssl_helper.cc:31: 
On 2011/03/01 19:10:37, Peter Kasting wrote:
> Nit: This blank line can stay

Done.

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:100: #include
"content/browser/tab_contents/infobar_delegate.h"
On 2011/03/01 19:10:37, Peter Kasting wrote:
> Nit: Can this disappear?

Removed.

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/ui/gtk/infoba...
File chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.h (right):

http://codereview.chromium.org/6598057/diff/6001/chrome/browser/ui/gtk/infoba...
chrome/browser/ui/gtk/infobars/confirm_infobar_gtk.h:10: #include
"chrome/browser/tab_contents/confirm_infobar_delegate.h"
On 2011/03/01 19:10:37, Peter Kasting wrote:
> Nit: Forward declare instead of adding this

I can't because of line 28.

[tfarina, 2011-03-02 16:20:34]

On 2011/03/01 19:14:59, John Abd-El-Malek wrote:
> btw if you have time, if you can move content\browser\infobar_delegate.* to
the
> files you're deleting here, that'd be great.  I moved them and then we decided
> they should have stayed.

Sure, I'll move them back to chrome/browser/tab_contents/infobar_delegate* in a
followup CL.