Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 659803005: Last round of effect->processor (for now) (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@factory
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update comments #

Patch Set 3 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M include/gpu/GrBackendProcessorFactory.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
M include/gpu/GrCoordTransform.h View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
bsalomon
6 years, 2 months ago (2014-10-15 18:11:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659803005/40001
6 years, 2 months ago (2014-10-15 18:28:59 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-15 18:29:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/58)
6 years, 2 months ago (2014-10-15 18:48:32 UTC) #6
joshualitt
On 2014/10/15 18:48:32, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-16 00:55:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659803005/40001
6 years, 2 months ago (2014-10-16 01:28:38 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 01:34:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as f2765410ba8adfe934b8d92e52ccc2a847934c61

Powered by Google App Engine
This is Rietveld 408576698