Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 659803004: Some cleanup in processor header files. (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@ccmat
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : minor cleanup #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -75 lines) Patch
M include/gpu/GrFragmentProcessor.h View 1 2 2 chunks +3 lines, -12 lines 0 comments Download
M include/gpu/GrGeometryProcessor.h View 2 chunks +5 lines, -14 lines 0 comments Download
M include/gpu/GrProcessor.h View 1 7 chunks +24 lines, -17 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 3 chunks +9 lines, -18 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
bsalomon
6 years, 2 months ago (2014-10-15 17:20:22 UTC) #1
joshua.litt
On 2014/10/15 17:20:22, bsalomon wrote: lgtm
6 years, 2 months ago (2014-10-15 17:29:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659803004/40001
6 years, 2 months ago (2014-10-15 17:53:08 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 18:05:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 98b33ebe6f66ed59b023cf16a09c0a40eb4510ce

Powered by Google App Engine
This is Rietveld 408576698