[Password Generation] Always query password forms via Autofill

components/autofill/core/browser/form_structure.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 87 matching lines @@
   // This is used when we receive server data for form fields.  At that time,
   // we may have more known fields than just the number of fields we matched
   // heuristically.
   void UpdateAutofillCount();
 
   // Returns true if this form matches the structural requirements for Autofill.
   bool ShouldBeParsed() const;
 
   // Returns true if we should query the crowdsourcing server to determine this
   // form's field types.  If the form includes author-specified types, this will
-  // return false.
+  // return false unless there are password fields in the form. If there are no
+  // password fields the assumption is that the author has expressed their
+  // intent and crowdsourced data should not be used to override this. Password
+  // fields are different because there is no way to specify password generation
+  // directly.
   bool ShouldBeCrowdsourced() const;
 
   // Sets the field types to be those set for |cached_form|.
   void UpdateFromCache(const FormStructure& cached_form);
 
   // Logs quality metrics for |this|, which should be a user-submitted form.
   // This method should only be called after the possible field types have been
   // set for each field.  |interaction_time| should be a timestamp corresponding
   // to the user's first interaction with the form.  |submission_time| should be
   // a timestamp corresponding to the form's submission.
@@ skipping 92 matching lines @@
   // include multiple fields of the same autofill type (with some exceptions, as
   // described in the implementation).  Sections are furthermore distinguished
   // as either credit card or non-credit card sections.
   // If |has_author_specified_sections| is true, only the second pass --
   // distinguishing credit card sections from non-credit card ones -- is made.
   void IdentifySections(bool has_author_specified_sections);
 
   // Returns true if field should be skipped when talking to Autofill server.
   bool ShouldSkipField(const FormFieldData& field) const;
 
+  // Returns true if the request was made for passwords only, and non-password
+  // fields should respect the autofill values set by the user.
+  bool ShouldSkipProcessingNonPasswordFields() const;
+
   size_t active_field_count() const;
 
   // The name of the form.
   base::string16 form_name_;
 
   // The source URL.
   GURL source_url_;
 
   // The target URL.
   GURL target_url_;
@@ skipping 14 matching lines @@
   std::string form_signature_field_names_;
 
   // Whether the server expects us to always upload, never upload, or default
   // to the stored upload rates.
   UploadRequired upload_required_;
 
   // Whether the form includes any field types explicitly specified by the site
   // author, via the |autocompletetype| attribute.
   bool has_author_specified_types_;
 
+  // True if the form contains at least one password field.
+  bool has_password_field_;
+
   DISALLOW_COPY_AND_ASSIGN(FormStructure);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_