Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 659793004: Fix DMWriteTask to write PDF files correctly (Closed)

Created:
6 years, 2 months ago by hal.canary
Modified:
6 years, 2 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix DMWriteTask to write PDF files correctly Previously, it was not rewinding the asset. Committed: https://skia.googlesource.com/skia/+/daf36c1524bcfd25416c0f85e288554f369e5090

Patch Set 1 : Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M dm/DMWriteTask.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hal.canary
PTAL
6 years, 2 months ago (2014-10-17 21:24:17 UTC) #3
bungeman-skia
lgtm
6 years, 2 months ago (2014-10-17 21:29:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659793004/20001
6 years, 2 months ago (2014-10-17 21:30:03 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 21:36:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as daf36c1524bcfd25416c0f85e288554f369e5090

Powered by Google App Engine
This is Rietveld 408576698