Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 659793002: DevTools: repair WorkerDevToolsSanityTest.InspectSharedWorker browser test (Closed)

Created:
6 years, 2 months ago by yurys
Modified:
6 years, 2 months ago
Reviewers:
vsevik, loislo
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: repair WorkerDevToolsSanityTest.InspectSharedWorker browser test This change depends on Blink r183742. BUG=89845, 403007 Committed: https://crrev.com/48be075ff1ad62ce491ed675601e4b63b10c2fc8 Cr-Commit-Position: refs/heads/master@{#299869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 9 chunks +28 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yurys
6 years, 2 months ago (2014-10-15 12:39:46 UTC) #2
vsevik
lgtm
6 years, 2 months ago (2014-10-15 12:42:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659793002/1
6 years, 2 months ago (2014-10-16 08:11:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 09:04:31 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 09:05:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48be075ff1ad62ce491ed675601e4b63b10c2fc8
Cr-Commit-Position: refs/heads/master@{#299869}

Powered by Google App Engine
This is Rietveld 408576698