content/browser/frame_host/navigator_impl.cc - Issue 659773002: New histogram to track overhead time spent around beforeunload event + fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 659773002: New histogram to track overhead time spent around beforeunload event + fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing CR comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index 584f950b44185549ae195358c7322d4d71af7887..856202eae3e09681cbc40d7b36585f1822fc238a 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -887,7 +887,6 @@ void NavigatorImpl::RecordNavigationMetrics(

navigation_data_->start_time_ -

navigation_data_->before_unload_delay_;

if (navigation_data_->is_restoring_from_last_session_) {

- DCHECK(!navigation_data_->before_unload_delay_.InMicroseconds());

UMA_HISTOGRAM_TIMES(

"Navigation.TimeToCommit_SessionRestored",

time_to_commit);

« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')