tools/metrics/histograms/histograms.xml - Issue 659773002: New histogram to track overhead time spent around beforeunload event + fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 659773002: New histogram to track overhead time spent around beforeunload event + fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing CR comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index dd89b52f6e84b34323b6c4b3884c4ed45bea44c8..81eab6c1e0e8bb0f6f279abc0ab7884efebf7944 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -14008,6 +14008,16 @@ Therefore, the affected-histogram name has to have at least one dot in it.

<summary>The scheme of the URL for each main-frame navigation.</summary>

</histogram>

+<histogram name="Navigation.OnBeforeUnloadOverheadTime" units="milliseconds">

+ <owner>carlosk@chromium.org</owner>

+ <summary>

+ Overhead time spent handling the OnBeforeUnload event from the browser

+ standpoint. More precisely, it is the total time between dispatch and

+ acknowledgment of the BeforeUnload event on the browser side, minus the

+ actual time spent executing the BeforeUnload handlers on the renderer side.

+ </summary>

+</histogram>

<owner>haitaol@chromium.org</owner>

<owner>donnd@chromium.org</owner>

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/browser/frame_host/render_frame_host_impl.cc ('k') | no next file » | no next file with comments »