Issue 659763002: Revert of RenderHostImpl::AddRoute - Turn a DCHECK to CHECK()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 659763002: Revert of RenderHostImpl::AddRoute - Turn a DCHECK to CHECK() (Closed)

Created:
6 years, 2 months ago by rmcilroy

Modified:
6 years, 2 months ago

Reviewers:
Hajime Morrita, kareng, nasko

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of RenderHostImpl::AddRoute - Turn a DCHECK to CHECK() (patchset #3 id:40001 of https://codereview.chromium.org/657613003/) Reason for revert: This broke the perf bots, details in crbug.com/423691 BUG=423691 Original issue's description: > RenderHostImpl::AddRoute - Turn a DCHECK to CHECK() > > This is to narrow down the cause of a crash bug and > likely to crash. Please revert and let me know > if you see this in the wild. > > R=nasko@chromium.org, kareng@chromium.org > BUG=381990, 415059 > > Committed: https://crrev.com/40e8a27bfd3c51ca92136c796d50e3f3a0d86c04 > Cr-Commit-Position: refs/heads/master@{#299591} TBR=kareng@chromium.org,nasko@chromium.org,morrita@chromium.org NOTREECHECKS=true NOTRY=true BUG=381990, 415059 Committed: https://crrev.com/f68ff6ec8cafe214f3ca99e2df9ca20b83f421ba Cr-Commit-Position: refs/heads/master@{#299669}

Created: 6 years, 2 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -25 lines)			Patch
	M	content/browser/renderer_host/render_process_host_impl.cc	View		2 chunks	+2 lines, -25 lines	0 comments	Download

Total messages: 4 (0 generated)

rmcilroy

Created Revert of RenderHostImpl::AddRoute - Turn a DCHECK to CHECK()

6 years, 2 months ago (2014-10-15 10:25:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659763002/1

6 years, 2 months ago (2014-10-15 10:26:49 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-15 10:28:19 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f68ff6ec8cafe214f3ca99e2df9ca20b83f421ba
Cr-Commit-Position: refs/heads/master@{#299669}