Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 659753003: [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (Closed)

Created:
6 years, 2 months ago by nednguyen
Modified:
6 years, 2 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Set the number of attempts to retry a test to 1 **SHERIFFS: if telemetry perf tests on waterfall become more flaky, this patch can be safely reverted. BUG=422339 Committed: https://crrev.com/f5b75f261be7779ccca14d09ddaabb3e4ee5ee03 Cr-Commit-Position: refs/heads/master@{#299716}

Patch Set 1 #

Patch Set 2 : Fix page_runner_unittest.PageRunnerTests.testRetryOnBrowserCrash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/telemetry/telemetry/page/page_runner_unittest.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
nednguyen
6 years, 2 months ago (2014-10-15 15:45:50 UTC) #2
tonyg
lgtm!! I do wonder whether it's worth a note in the patch description to sheriffs ...
6 years, 2 months ago (2014-10-15 15:51:22 UTC) #3
nednguyen
On 2014/10/15 15:51:22, tonyg wrote: > lgtm!! > > I do wonder whether it's worth ...
6 years, 2 months ago (2014-10-15 15:54:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659753003/1
6 years, 2 months ago (2014-10-15 15:56:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659753003/20001
6 years, 2 months ago (2014-10-15 15:59:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-15 18:13:06 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f5b75f261be7779ccca14d09ddaabb3e4ee5ee03 Cr-Commit-Position: refs/heads/master@{#299716}
6 years, 2 months ago (2014-10-15 18:13:58 UTC) #10
hendrikw
On 2014/10/15 18:13:58, I haz the power (commit-bot) wrote: > Patchset 2 (id:??) landed as ...
6 years, 2 months ago (2014-10-18 19:58:17 UTC) #11
hendrikw
6 years, 2 months ago (2014-10-18 19:58:52 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/661303002/ by hendrikw@chromium.org.

The reason for reverting is: Possible cause of gpu telemetry bot flake.

Powered by Google App Engine
This is Rietveld 408576698